Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch protection rule for release branches #6

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Add branch protection rule for release branches #6

merged 1 commit into from
Aug 23, 2024

Conversation

windsource
Copy link
Contributor

As defined in eclipse-ankaios/ankaios#355, we need release branches and want to apply branch protections rules for them.

@windsource windsource requested a review from a team as a code owner August 23, 2024 12:36
Copy link
Contributor

This is your friendly self-service bot.

Thank you for raising a pull request to update the configuration of your GitHub organization.
You can manually add reviewers to this PR to eventually enable auto-merging.

The following conditions need to fulfilled for auto-merging to be available:

  • valid configuration
  • approved by a project lead
  • does not require any secrets
  • does not update settings only accessible via the GitHub Web UI
  • does not remove any resource
Otterdog commands and options

You can trigger otterdog actions by commenting on this PR:

  • /otterdog team-info checks the team / org membership for the PR author
  • /otterdog validate validates the configuration change
  • /otterdog validate info validates the configuration change, printing also validation infos
  • /otterdog check-sync checks if the base ref is in sync with live settings
  • /otterdog merge merges and applies the changes if the PR is eligible for auto-merging (only accessible for the author)
  • /otterdog done notifies the self-service bot that a required manual apply operation has been performed (only accessible for members of the admin team)
  • /otterdog apply re-apply a previously failed attempt (only accessible for members of the admin team)

Copy link
Contributor

This is your friendly self-service bot.

The author (windsource) of this PR is associated with this organization in the role of MEMBER.

Additionally, windsource is a member of the following teams:

Copy link
Contributor

This is your friendly self-service bot.
Please find below the validation of the requested configuration changes:

Diff for d4fa762
Organization automotive.ankaios[id=eclipse-ankaios]
  there have been 1 validation infos, enable verbose output with '-v' to to display them.

+  add branch_protection_rule[pattern="release-**", repository="ankaios"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    bypass_pull_request_allowances    = []
+    dismisses_stale_reviews           = false
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "release-**"
+    require_last_push_approval        = false
+    required_approving_review_count   = "1"
+    required_status_checks            = [
+      "eclipse-eca-validation:eclipsefdn/eca"
+      "Build and run system tests Linux amd64"
+      "Run unit tests Linux amd64"
+      "Build Linux amd64 debian package"
+      "Build Linux arm64 debian package"
+      "Build requirements tracing"
+      "Check if documentation has changed"
+      "Deploy documentation"
+    ],
+    requires_code_owner_reviews       = false
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = true
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = true
+    requires_status_checks            = true
+    requires_strict_status_checks     = false
+    restricts_pushes                  = false
+    restricts_review_dismissals       = false
+  }
  
  Plan: 1 to add, 0 to change, 0 to delete.

Copy link
Contributor

This is your friendly self-service bot. The current configuration is in-sync with the live settings. 🚀

Copy link
Contributor

This is your friendly self-service bot.
This Pull Request is eligible for auto-merging as it passed the following checks:

  • valid configuration
  • approved by a project lead
  • does not require any secrets
  • does not update settings only accessible via the GitHub Web UI
  • does not remove any resource

In order to automatically merge and apply the changes, add a comment /otterdog merge. 🚀

@windsource windsource requested a review from inf17101 August 23, 2024 12:37
Copy link
Contributor

@inf17101 inf17101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@windsource
Copy link
Contributor Author

/otterdog merge

@eclipse-otterdog eclipse-otterdog bot merged commit e83becb into eclipse-ankaios:main Aug 23, 2024
3 checks passed
Copy link
Contributor

This is your friendly self-service bot.

The following changes have been successfully applied:

Organization automotive.ankaios[id=eclipse-ankaios]
  there have been 1 validation infos, enable verbose output with '-v' to to display them.

+  add branch_protection_rule[pattern="release-**", repository="ankaios"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    bypass_pull_request_allowances    = []
+    dismisses_stale_reviews           = false
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "release-**"
+    require_last_push_approval        = false
+    required_approving_review_count   = "1"
+    required_status_checks            = [
+      "eclipse-eca-validation:eclipsefdn/eca"
+      "Build and run system tests Linux amd64"
+      "Run unit tests Linux amd64"
+      "Build Linux amd64 debian package"
+      "Build Linux arm64 debian package"
+      "Build requirements tracing"
+      "Check if documentation has changed"
+      "Deploy documentation"
+    ],
+    requires_code_owner_reviews       = false
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = true
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = true
+    requires_status_checks            = true
+    requires_strict_status_checks     = false
+    restricts_pushes                  = false
+    restricts_review_dismissals       = false
+  }

  
  Applying changes:


  Done.
  
  Executed plan: 1 added, 0 changed, 0 deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants