-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix agent reconnect does not work #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just had a couple of small findings.
I have not tested it yet, but I'll do so and we can merge after the fixes and the test.
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All done here. The handling also works, but the documentation of the exceptions needs to be updated. As this is out of the scope of the current ticket, I created a new one: #47
Issues: #39
Solution
When the agent gets disconnected, the sdk enters a routine where it tries to send the
hello
message over and over. Succeeding in sending it means the agent is back. The agent will receive a number ofhello
messages when starting, but this is ok because the first one will be taken into account (and much needed by the whole interaction) and the rest of them will be ignored, thus the communication can continue.Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.