Fix the filtering of the complete state - Updating the unit tests #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kaloyan <krucod3@users.noreply.github.com>
krucod3
reviewed
Jul 25, 2024
There was a problem hiding this comment.
First part of review is done. I still need to review runtime_manager.rs and get_state.rs
I think we should add a generate_test_proto_complete_state function family that:
- generates an empty one with the proper api version
- accepts an array of tuples (impl Into, ank_base::Workload)
krucod3
reviewed
Jul 26, 2024
|
There are still some warnings in the build... |
krucod3
merged commit 877acca
into
eclipse-ankaios:196_fix_the_filtering_of_the_complete_state
9 of 10 checks passed
krucod3
added a commit
that referenced
this pull request
Jul 31, 2024
* optimize mem usage in wl state db + prepare for new wl state structure * Add ControlInterfaceAccess to protobuf internal representation Issue-Id: #22 * Introduce PATH_SEPARATOR constant Issue-Id: #22 * Restructuring the workload states object as a searchable map * Fix indentation * Fix clippy warning Issue-Id: #22 * Remove accidentally installed package from devcontainer Issue-Id: #22 * Add first version of authorizer Issue-Id: #22 * Exchange control interface if access rules are changed Issue-Id: #22 * Add file missed in last commits Issue-Id: #22 * Remove unused imports Issue-Id: #22 * Mark code not used in tests with allow(dead_code) Issue-Id: #22 * Change authorizer to support read and write Issue-Id: #22 * Fix example startup state with control interface access rights * Fix rust example with control interface access rights * Fix python control interface example with control interface access rights * Fix nodejs example with control interface access rights * Fix cpp example with control interface access rights * Make allow and deny rules empty by default * Remove comments Issue-Id: #22 Co-authored-by: Oliver Klapper <oliver.klapper@elektrobit.com> * Fix proto files according to review findings Issue-Id: #22 * Remove unwrap in configuration comparison Issue-Id: #22 * Simplify control interface path comparison Issue-Id: #22 * Update common/src/objects/workload_states_map.rs Co-authored-by: Oliver <42932060+inf17101@users.noreply.github.com> * Add upgrading info * Small fixes * Fix requirements tracing * Add logs explaining why a request was allowed/denied Issue-Id: #22 * Correct handling of empty string as mask/rule Issue-Id: #22 * Fix typo Issue-Id: #22 * Remove denyRules from example * Replace fold with simple for loop Issue-Id: #22 * Fix the filtering og the complete state * Remove double conversion in cli * Construct empty string with default * Refactor filtering of list workloads * Add documentation in ank_base.proto * Simplify api version filter and remove clone * Add swdd and utset and fix linkage * Fix cpp_control_interface examples * Make tags, dependencies and restart policy optional * Remove tags and dependencies allocation in cpp example * Fix control_interface examples (#321) Fixed python, nodejs and rust control_interface examples due to change to ank_base.proto * Remove unneeded use * Fix the filtering of the complete state - Updating the unit tests (#323) * Update utests * Update tests * Fix failing server_state unit tests * Fix warnings in unit tests * Fix PR findings * Fix PR findings --------- Co-authored-by: Kaloyan <krucod3@users.noreply.github.com> * Fix all warnings * Fix a todo in a utest * Fix last set of warnings * Add additional information to upgrading section * Apply suggestions from code review Co-authored-by: Christoph Hamm <130038849+christoph-hamm@users.noreply.github.com> * Fix the rest of the review findings --------- Co-authored-by: Christoph Hamm <130038849+christoph-hamm@users.noreply.github.com> Co-authored-by: Oliver Klapper <oliver.klapper@elektrobit.com> Co-authored-by: Oliver <42932060+inf17101@users.noreply.github.com> Co-authored-by: Tomuta Gabriel <gaby_unalaq@yahoo.com> Co-authored-by: RaresHorju <36081886+HorjuRares@users.noreply.github.com> Co-authored-by: Kaloyan <krucod3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #
Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.