Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utests and stests for control interface authorization #324

Merged
merged 70 commits into from
Aug 5, 2024
Merged

Add utests and stests for control interface authorization #324

merged 70 commits into from
Aug 5, 2024

Conversation

christoph-hamm
Copy link
Contributor

@christoph-hamm christoph-hamm commented Jul 24, 2024 •
edited by inf17101
Loading

Issues: #22

Definition of Done

The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

krucod3 and others added 30 commits June 14, 2024 12:26
@krucod3
optimize mem usage in wl state db + prepare for new wl state structure
9576b7e
@krucod3
Merge remote-tracking branch 'origin/main' into 22_authorize_requests
a51d57f
@christoph-hamm
Add ControlInterfaceAccess to protobuf internal representation
2abfbf7 
Issue-Id: #22
@christoph-hamm
Introduce PATH_SEPARATOR constant
7ef70a8 
Issue-Id: #22
@krucod3
Restructuring the workload states object as a searchable map
b2478bd
@krucod3
Merge branch '22_authorize_requests' of github.com:eclipse-ankaios/an…
15159c6 
…kaios into 22_authorize_requests
@krucod3
Merge remote-tracking branch 'origin/main' into 22_authorize_requests
4b0db63
@krucod3
Fix indentation
3b0a37e
@christoph-hamm
Fix clippy warning
f4fc608 
Issue-Id: #22
@christoph-hamm
Remove accidentally installed package from devcontainer
50fdcfc 
Issue-Id: #22
@christoph-hamm
Add first version of authorizer
908fe42 
Issue-Id: #22
@christoph-hamm
Exchange control interface if access rules are changed
0f863b0 
Issue-Id: #22
@christoph-hamm
Add file missed in last commits
2505041 
Issue-Id: #22
@christoph-hamm
Remove unused imports
9d31065 
Issue-Id: #22
@christoph-hamm
Mark code not used in tests with allow(dead_code)
1472cb7 
Issue-Id: #22
@krucod3
Merge remote-tracking branch 'origin/main' into 22_authorize_requests
0915055
@christoph-hamm
Change authorizer to support read and write
5d7782c 
Issue-Id: #22
@inf17101
Fix example startup state with control interface access rights
a0210e8
@inf17101
Fix rust example with control interface access rights
400bc43
@inf17101
Fix python control interface example with control interface access ri…
3144b8b 
…ghts
@inf17101
Fix nodejs example with control interface access rights
9170b87
@inf17101
Fix cpp example with control interface access rights
a572b1d
@inf17101
Make allow and deny rules empty by default
29504e9
@christoph-hamm @inf17101
Remove comments
a576c2a 
Issue-Id: #22
Co-authored-by: Oliver Klapper <oliver.klapper@elektrobit.com>
@christoph-hamm
Fix proto files according to review findings
146abe8 
Issue-Id: #22
@christoph-hamm
Remove unwrap in configuration comparison
0ebbdcd 
Issue-Id: #22
@christoph-hamm
Simplify control interface path comparison
2a9fd55 
Issue-Id: #22
@krucod3 @inf17101
Update common/src/objects/workload_states_map.rs
cf72fe6 
Co-authored-by: Oliver <42932060+inf17101@users.noreply.github.com>
@krucod3
Add upgrading info
d34e743
@krucod3
Merge branch '22_authorize_requests' of github.com:eclipse-ankaios/an…
38720f0 
…kaios into 22_authorize_requests
lingnoi
lingnoi requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@lingnoi lingnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small findings.

agent/src/control_interface/authorizer.rs Outdated Show resolved Hide resolved
tests/stests/control_interface/authorization.robot Show resolved Hide resolved
lingnoi
lingnoi reviewed Jul 31, 2024
View reviewed changes
tests/resources/image/src/main.rs Outdated Show resolved Hide resolved
tests/stests/control_interface/authorization.robot Outdated Show resolved Hide resolved
tests/stests/control_interface/authorization.robot Outdated Show resolved Hide resolved
tests/stests/control_interface/authorization.robot Outdated Show resolved Hide resolved
lingnoi
lingnoi approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@lingnoi lingnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

inf17101
inf17101 reviewed Aug 2, 2024
View reviewed changes
doc/docs/reference/control-interface.md Outdated Show resolved Hide resolved
doc/docs/reference/control-interface.md Outdated Show resolved Hide resolved
doc/docs/reference/control-interface.md Outdated Show resolved Hide resolved
doc/docs/reference/control-interface.md Outdated Show resolved Hide resolved
christoph-hamm and others added 2 commits August 2, 2024 16:13
@christoph-hamm
Merge branch 'main' into 22_add_utests_and_stests
c0f8ee4
@christoph-hamm @inf17101
Apply suggestions from code review
e48a6d2 
Co-authored-by: Oliver <42932060+inf17101@users.noreply.github.com>
@christoph-hamm christoph-hamm force-pushed the 22_add_utests_and_stests branch from e41636e to e48a6d2 Compare August 5, 2024 08:15
@krucod3 krucod3 mentioned this pull request Aug 5, 2024
Open
3 tasks
inf17101
inf17101 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@inf17101 inf17101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@krucod3 krucod3 merged commit 4082899 into main Aug 5, 2024
10 checks passed
@krucod3 krucod3 deleted the 22_add_utests_and_stests branch August 5, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingnoi lingnoi lingnoi approved these changes

@inf17101 inf17101 inf17101 approved these changes

Assignees
No one assigned
Labels
ignore-for-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christoph-hamm @inf17101 @lingnoi @krucod3