Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a script to update version of Ankaios #339

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

windsource
Copy link
Contributor

@windsource windsource commented Aug 5, 2024

Issue-Id: #337

Definition of Done

The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

Copy link
Contributor

@inf17101 inf17101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review finished. Two small findings.

A hint inside the prepare release documentation that this script shall be executed would be useful: Prepare Release

tools/update_version.sh Outdated Show resolved Hide resolved
tools/update_version.sh Show resolved Hide resolved
Copy link
Contributor

@inf17101 inf17101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM👍

@inf17101 inf17101 merged commit fda0fa1 into main Aug 19, 2024
10 checks passed
@inf17101 inf17101 deleted the 337_script_updating_version branch August 19, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants