-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor control interface #345
Refactor control interface #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The renamings are fine. Just one small variable name finding.
In addition, we shall refactor the duplicated methods "create_control_interface(...)" as well. I think it is not good, that the ControlInterfaceInfo struct contains a method "create_control_interface" in general.
Please test the control interface examples one times. |
I have tested the examples and their are working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, it looks fine to me.
Ok thank you. I will step once through the swdd requirements. So please wait with the merge. |
@windsource: I have adapted the swdds and fixed also some linkage of existing tests. |
Refactoring decisions are explained in a comment inside #322.
Changes
Renamed some structs from the control_interface:
Moved files related to the control_interface:
Got rid of wildcard imports.
Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.