Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer to Rust 1.80.1 #352

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Update devcontainer to Rust 1.80.1 #352

merged 7 commits into from
Aug 22, 2024

Conversation

windsource
Copy link
Contributor

@windsource windsource commented Aug 20, 2024

For #348 we need to update to Rust 1.80.1. The previous base container image mcr.microsoft.com/devcontainers/rust does not provide that Rust version. For that reason I have also changed the base image version to ubuntu:24.04 and used rustup to install Rust.

Issues: #89

Definition of Done

The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

@inf17101
Copy link
Contributor

I have tested the ubuntu version with the following:

  • debug build
  • aarch64 cross build
  • running all system tests
  • serving the user documentation
  • generate test coverage
  • running an control interface example

No findings. Runs smooth.

@windsource
Copy link
Contributor Author

Comparing the sizes:

Image Base image Size for amd64
ghcr.io/eclipse-ankaios/devcontainer-base:0.9.2 mcr.microsoft.com/devcontainers/rust:1-1-bookworm 4.28 GB
ghcr.io/eclipse-ankaios/devcontainer-base:0.10.0 ubuntu:24.04 3.66 GB

@inf17101
Copy link
Contributor

inf17101 commented Aug 22, 2024

I have also tried it out on another platform Mac M1, tested the build and the stests and this works.

@inf17101
Copy link
Contributor

I suggest to add the following lines to .cargo/config.toml:

[target.x86_64-unknown-linux-musl]
linker="x86_64-linux-gnu-gcc"

Then I am able to build the default target x86... on Mac M1 with the default debug build command cargo build.

@inf17101
Copy link
Contributor

I have tested in addition on Mac M1:

  • coverage report
  • building the user documenation

It works.

Copy link
Contributor

@inf17101 inf17101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@inf17101 inf17101 merged commit 3120962 into main Aug 22, 2024
10 checks passed
@inf17101 inf17101 deleted the update_rust branch August 22, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants