-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devcontainer to Rust 1.80.1 #352
Conversation
I have tested the ubuntu version with the following:
No findings. Runs smooth. |
Comparing the sizes:
|
I have also tried it out on another platform Mac M1, tested the build and the stests and this works. |
Issue-Id: #89
I suggest to add the following lines to [target.x86_64-unknown-linux-musl]
linker="x86_64-linux-gnu-gcc" Then I am able to build the default target x86... on Mac M1 with the default debug build command |
I have tested in addition on Mac M1:
It works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
For #348 we need to update to Rust 1.80.1. The previous base container image
mcr.microsoft.com/devcontainers/rust
does not provide that Rust version. For that reason I have also changed the base image version toubuntu:24.04
and usedrustup
to install Rust.Issues: #89
Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.