Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix complete state filtering with control interface access #359

Merged

Conversation

krucod3
Copy link
Contributor

@krucod3 krucod3 commented Aug 27, 2024

Issues: #349

Definition of Done

The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

Copy link
Contributor

@inf17101 inf17101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked out the branch and tested the get state on the cli with the new startConfig.yaml and I tested the python control interface example with trying to get the complete state. Both works.
Also the utest seems to be fine, since it fails when removing the field_attribute settings.

LTGM 👍

@krucod3 krucod3 merged commit 9bf2885 into main Aug 27, 2024
10 checks passed
@krucod3 krucod3 deleted the 349_fix_complete_state_filtering_with_control_interface_access branch August 27, 2024 10:36
@inf17101 inf17101 mentioned this pull request Aug 27, 2024
1 task
@krucod3 krucod3 added bug Something isn't working. Issue will appear in the change log "Bug Fixes" and removed ready for review labels Aug 27, 2024
@windsource windsource changed the title 349 fix complete state filtering with control interface access Fix complete state filtering with control interface access Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. Issue will appear in the change log "Bug Fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants