Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reconnected agents not getting deleted workload #367

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Fix reconnected agents not getting deleted workload #367

merged 3 commits into from
Sep 10, 2024

Conversation

GabyUnalaq
Copy link
Contributor

@GabyUnalaq GabyUnalaq commented Sep 5, 2024 •
edited
Loading

Issue: #358

  • Create Concept for the fix (detailed in the issue)
  • Create ServerHello
  • Fix utests and requirements
  • All steps in CONTRIBUTING.md have been handled

@krucod3 krucod3 added bug Something isn't working. Issue will appear in the change log "Bug Fixes" good first issue Good for newcomers labels Sep 5, 2024
@krucod3 krucod3 self-requested a review September 5, 2024 06:32
@krucod3 krucod3 added ready for review and removed good first issue Good for newcomers labels Sep 5, 2024
krucod3
krucod3 requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done, findings documented.

We should also mention the new ServerHello message in the requirements. Please have a look how AgentHello is described in both agent and server for some inspiration.

grpc/proto/grpc_api.proto Outdated Show resolved Hide resolved
grpc/proto/grpc_api.proto Outdated Show resolved Hide resolved
grpc/src/from_server_proxy.rs Outdated Show resolved Hide resolved
agent/src/runtime_manager.rs Outdated Show resolved Hide resolved
krucod3
krucod3 reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small finding in the requirements changes.

server/doc/swdesign/README.md Show resolved Hide resolved
krucod3
krucod3 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@krucod3 krucod3 merged commit 8dff293 into eclipse-ankaios:main Sep 10, 2024
10 checks passed
@krucod3 krucod3 mentioned this pull request Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krucod3 krucod3 krucod3 approved these changes

Assignees

@GabyUnalaq GabyUnalaq

Labels
bug Something isn't working. Issue will appear in the change log "Bug Fixes" ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GabyUnalaq @krucod3