Enforce naming conventions #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krucod3
reviewed
Sep 10, 2024
krucod3
reviewed
Sep 10, 2024
krucod3
reviewed
Sep 11, 2024
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
krucod3
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Some additional open points:
We should also enforce the agent name restrictions in the agent startup arguments.
Additionally we need to document the new constraints somewhere in our documentation (in doc/docs). The naming constraints can be mentioned as notes in complete-state.md and in the quickstart.md. Additionally they should be present in the documentation of the proto file. The agent constraints must also be added in the documentation of the cli parameters of the ank-agent.
It would also be great if we also add some hints about the workload names and how DNS can be enabled for workloads. For this part we would probably need a separate file in the reference folder.
krucod3
reviewed
Sep 20, 2024
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
krucod3
reviewed
Sep 23, 2024
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
windsource
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #341
Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.