Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API version checks to all connections to Ankaios #380

Merged
merged 28 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
cf29678
Add API versions checks to all connections to Ankaios
krucod3 Sep 18, 2024
074e8b7
Stabilize stests
krucod3 Sep 25, 2024
bd21c09
Adding API checks for the Control Interface.
krucod3 Sep 25, 2024
8c889ef
Merge remote-tracking branch 'origin/main' into 14_api_version_checks…
krucod3 Sep 26, 2024
4c15245
Update preliminary expected Ankaios version
krucod3 Sep 26, 2024
8f499ac
Merge branch 'main' into 14_api_version_checks_for_connections
krucod3 Sep 26, 2024
0180a5a
Remove the unnecessary Box<[u8]> & fixed utests
krucod3 Sep 26, 2024
d5f5c51
Merge branch '14_api_version_checks_for_connections' of github.com:ec…
krucod3 Sep 26, 2024
e58336a
Update Cargo.lock
krucod3 Sep 26, 2024
8315774
Add unit tests for the Control Interface API version checks
krucod3 Sep 26, 2024
50a84fd
Improve stests
krucod3 Sep 27, 2024
ff54d8f
Make stest work in CI/CD too
krucod3 Sep 27, 2024
ff82926
Add stest for connection closed without control interface hello
krucod3 Sep 30, 2024
059fcfa
API version check: requirements & tracing
krucod3 Sep 30, 2024
e64b524
Add Control Interface Tester README
krucod3 Oct 1, 2024
6ffcfa3
Merge remote-tracking branch 'origin/main' into 14_api_version_checks…
krucod3 Oct 2, 2024
7431b72
Prior to this change,
krucod3 Oct 2, 2024
79430cb
Upgrading sections
krucod3 Oct 7, 2024
d2b2cf8
Merge remote-tracking branch 'origin/main' into 14_api_version_checks…
krucod3 Oct 14, 2024
3ff1f0e
Boxing big objects
krucod3 Oct 14, 2024
01455f7
Fix typo
krucod3 Oct 14, 2024
15fa2cb
Merge branch 'main' into 14_api_version_checks_for_connections
krucod3 Oct 18, 2024
208b39d
Handle the case of broken protobuf data.
krucod3 Oct 18, 2024
3ca1771
Apply suggestions from code review
krucod3 Oct 22, 2024
e26de82
Apply suggestions from code review
krucod3 Oct 22, 2024
a4058ee
Apply suggestions from code review
krucod3 Oct 22, 2024
a293746
Apply suggestions from code review
krucod3 Oct 22, 2024
8193991
Fox code review findings.
krucod3 Oct 22, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions agent/doc/swdesign/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2816,6 +2816,26 @@ Needs:
- impl
- utest

#### Agent closes Control Interface channel on missing initial `Hello`
`swdd~agent-closes-control-interface-on-missing-initial-hello~1`

Status: approved

When an Ankaios agent receives an initial message on the Control Interface that is different to the initial `Hello` message containing the supported Ankaios version by the workload or the provided version in the message is not compatible with the one of the agent, the agent shall:
* close the Control Interface connection by sending a `ConnectionClosed` message
* discontinuing reading new messages from the workload.

Comment:
The check for the supported by the agent version is done by a central function provided by the common library.

Tags:
- ControlInterface

Needs:
- impl
- utest
- stest

#### Agent converts from Control Interface proto request to internal object
`swdd~agent-converts-control-interface-message-to-ankaios-object~1`

Expand Down
Loading