Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workload config implementation #389

Merged
merged 75 commits into from
Oct 29, 2024
Merged

Add workload config implementation #389

merged 75 commits into from
Oct 29, 2024

Conversation

inf17101
Copy link
Contributor

@inf17101 inf17101 commented Oct 8, 2024 •
edited
Loading

Issues: #267

Definition of Done

The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

inf17101 and others added 21 commits October 1, 2024 16:18
@inf17101
Small draft code to try out handlebars
5dbf096
@inf17101
Write design decision for handlebars
ad62212
@inf17101
Add first swdds and first draft implementation
260b813
@inf17101
Fix reference and swdd tags
0eed241
@inf17101
Add swdd for config renderer
a0a7f1e
@inf17101
Update rendered workloads only when state is updated
75e63b5
@inf17101
Implement update logic of expanded workloads
6841368
@inf17101
Rename workload variables
ab38bfd
@inf17101
Skip rendering on no config assignment and introduce error type
44c072a
@inf17101
Fix update of config item only
f3a6c54
@inf17101
Remove in-place allocation of ConfigRenderer
9be64e1
@inf17101
Add comment
36daf58
@inf17101
Fix server state utests
f040eb8
@inf17101
Add config renderer utests
9d84050
@inf17101
Add update of configs utest and swdd
3bc5aee
@inf17101
Add configs update utests for server state
d2565b1
@inf17101
Rename update_state method
77b8e9e
@inf17101
Ignore configs for agent name handling in ank apply
033a6d3
@inf17101
Fix linkage in utest
2bc1683
@windsource
Add completions for configs in object field mask
667a60e 
Issue-Id: #267
@inf17101
Improve log output in ank cli
680ed15
@windsource windsource mentioned this pull request Oct 11, 2024
Closed
2 tasks
@inf17101 inf17101 added the enhancement New feature or request. Issue will appear in the change log "Features" label Oct 14, 2024
@inf17101 inf17101 self-assigned this Oct 14, 2024
@inf17101
Copy link
Contributor Author

@krucod3: merged the latest main branch to include the fix for the unstable stest. Pipeline is now passing again.

krucod3
krucod3 reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First part of review done. Still need to review docs and reqs in more details.

tests/resources/configs/manifest_with_configs.yaml Outdated Show resolved Hide resolved
tests/resources/configs/update_state_updated_config_item.yaml Outdated Show resolved Hide resolved
tests/stests/workloads/workload_configs_podman.robot Outdated Show resolved Hide resolved
common/src/objects/state.rs Outdated Show resolved Hide resolved
common/doc/swdesign/README.md Outdated Show resolved Hide resolved
server/src/ankaios_server/server_state.rs Show resolved Hide resolved
server/src/ankaios_server/server_state.rs Outdated Show resolved Hide resolved
server/src/ankaios_server/server_state.rs Outdated Show resolved Hide resolved
ank/src/cli_commands/apply_manifests.rs Outdated Show resolved Hide resolved
server/doc/swdesign/README.md Outdated Show resolved Hide resolved
inf17101 and others added 10 commits October 29, 2024 14:29
@inf17101 @krucod3
Wording in comment
c09e0d3 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101
Rename api_format method
f08de11
@inf17101
Fix naming convention swdd rationale
2d3d9c6
@inf17101
Change swdd for selecting workloads for agents
16f5cb3
@inf17101 @krucod3
Add newline to swdd rationale
2c35a9a 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101 @krucod3
Rename utest
0d1ea19 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101 @krucod3
Use mockall double for import
80809ca 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101 @krucod3
Output error message
56c836a 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101 @krucod3
Space in utest linkage
502d503 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@inf17101 @krucod3
Change comment in utest
2d7e7e3 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
@krucod3 krucod3 mentioned this pull request Oct 29, 2024
Merged
1 task
krucod3
krucod3 reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs are now reviewed.

doc/docs/reference/startup-configuration.md Outdated Show resolved Hide resolved
doc/docs/usage/quickstart.md Outdated Show resolved Hide resolved
doc/docs/reference/startup-configuration.md Outdated Show resolved Hide resolved
@inf17101 inf17101 mentioned this pull request Oct 29, 2024
Closed
@inf17101
Copy link
Contributor Author

inf17101 commented Oct 29, 2024 •
edited
Loading

Merged main into branch. There were no conflicts.

@inf17101 @krucod3
Revert to normal yaml string
8297098 
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
krucod3
krucod3 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@krucod3 krucod3 merged commit f640b80 into main Oct 29, 2024
10 checks passed
@krucod3 krucod3 deleted the 267_workload_config_impl branch October 29, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krucod3 krucod3 krucod3 approved these changes

Assignees

@inf17101 inf17101

Labels
enhancement New feature or request. Issue will appear in the change log "Features" ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inf17101 @krucod3 @windsource