Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apiVersion not enforced for ank apply #408

Conversation

HorjuRares
Copy link
Contributor

@HorjuRares HorjuRares commented Nov 5, 2024

Issues: #395

Definition of Done

The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments

ank/doc/swdesign/README.md Outdated Show resolved Hide resolved
ank/doc/swdesign/README.md Outdated Show resolved Hide resolved
@krucod3 krucod3 added ready for review bug Something isn't working. Issue will appear in the change log "Bug Fixes" labels Nov 6, 2024
Co-authored-by: Kaloyan <36224699+krucod3@users.noreply.github.com>
Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@krucod3 krucod3 merged commit ee3986e into eclipse-ankaios:main Nov 6, 2024
10 checks passed
@HorjuRares HorjuRares deleted the 395_api_version_not_enforced_for_ank_apply branch November 11, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. Issue will appear in the change log "Bug Fixes" ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants