Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

body/label/text-property is not localized in XLSX output #1745

Closed
hdre-GFT opened this issue Jun 21, 2024 · 4 comments
Closed

body/label/text-property is not localized in XLSX output #1745

hdre-GFT opened this issue Jun 21, 2024 · 4 comments
Assignees
@speckyspooky
Labels
BugFix Change to correct issues
Milestone
4.17

Comments

@hdre-GFT
Copy link

Observed in BIRT Designer 4.16 and 4.13.

Report design:

<simple-property-list name="includeResource">
    <value>../resources/locale_test</value>
</simple-property-list>
...
<body>
    <label id="555547">
        <text-property name="text" key="myproperty">LOCALIZATION 1 FAILED!</text-property>
    </label>
    <table id="470">
        <property name="dataSet">data</property>
        <header>
            <row id="471">
                <cell id="473">
                    <label id="547">
                        <text-property name="text" key="myproperty">LOCALIZATION 2 FAILED!</text-property>
                    </label>
                </cell>
            </row>
        </header>
    </table>
</body>

The resource bundle consists of 1 file resources/locale_test.properties with the following one-liner:

myproperty=SUCCESS!

At least the web viewer and PDF outputs are correct.
In Excel output only the label in the table is localized.
See attachments.
locale_test.pdf
locale_test.xlsx
locale_test.zip
@speckyspooky speckyspooky added this to the 4.17 milestone Jun 21, 2024
@speckyspooky speckyspooky added the BugFix Change to correct issues label Jun 21, 2024
@speckyspooky speckyspooky self-assigned this Jun 21, 2024
@speckyspooky
Copy link
Contributor

Hello @hdre-GFT, I can confirm the problem and the issue is a very old one to it exists already with BIRT 4.8.
The problem is located into the spudsoft-excel emitter and the label-text-validation.
The code means: use at first the label text if it set and not the localization.

I will provide a fix for the issue.

In the meantime you can use a workaround and add the label into the table too or also into a grid.

speckyspooky added a commit to speckyspooky/birt that referenced this issue Jun 21, 2024
@speckyspooky
Fix label localization for xlsx (eclipse-birt#1745)
d876c02
@merks
Copy link
Contributor

merks commented Jun 21, 2024

You’re awesome 😎

@speckyspooky
Copy link
Contributor

The fix is added with PR #1746

wimjongman pushed a commit that referenced this issue Jun 22, 2024
@speckyspooky
Fix label localization for xlsx (#1745) (#1746)
1369a85
@speckyspooky
Copy link
Contributor

The fix will be available with BIRT 4.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@speckyspooky speckyspooky

Labels
BugFix Change to correct issues
Projects
None yet
Milestone
4.17
Development

No branches or pull requests
3 participants
@merks @speckyspooky @hdre-GFT