Added image data URL handling to the excel cell content handler (#1237) #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speckyspooky
added
the
Enhancement
hvbtup
approved these changes
Mar 21, 2023
|
Can I start the merge of the pull request? |
Yes. |
|
Hey Thomas, since you are now a commiter, you can squash and merge the PR. Please use Squash and merge whenever merging so we do not get all the developer commits in. The workflow is to first ask for a review. Then if you have a positive review, you can SQ&M. |
|
Thanks Henning & Wim! The merge is done with SQ&M. |
|
Congratulations on your first merge. I hope many more will follow. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enhancement make the option of data url accessible for excel output which is located into text element based on image tag.