Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required dependencies of osgi-runtime (report generation) #1340 #1348

Closed

Conversation

speckyspooky
Copy link
Contributor

Added missing dependencies of osgi-runtime

@merks
Copy link
Contributor

merks commented Jun 24, 2023

I have the following working locally and comparing the two lib folders:

image

The soap mystery is more clear now because formerly that came from the saaj.jar. Also javax.xm.bind is missing and should be replaced by jakarta.xml.bind, which export javax packages, unless it was never relevant, but best not to make assumptions.

I really don't want to pull things from the designer product. Better that we pull everything from the target folder of the project itself.

I have a pull request coming and I thing it's better we abandon this one...

@merks
Copy link
Contributor

merks commented Jun 24, 2023

I think this fix is better and most probably more complete:

#1349

This fix pulls everything from the target folder of the project itself rather than pulling things from other products in other projects.

@speckyspooky
Copy link
Contributor Author

Ok, I'm with you.

My PR will finished in some minutes and I will not push them to the master.
I will wait your improved version so that I can do my retest with the latest version tomorrow.

@speckyspooky
Copy link
Contributor Author

I close the PR because the #1349 "Copy more content into the lib folder of birt-runtime-osgi"
implements the optimized and better version for the dependencies.

@speckyspooky speckyspooky deleted the issue-birt-1340-2 branch September 16, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants