-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prepared statement setNull() #1365 #1371
Fix prepared statement setNull() #1365 #1371
Conversation
@merks The jenkins error message are: Could you please assist here again. Thanks in advance. |
5a72947
to
78e9020
Compare
Note that any other PRs you started before the target platform was fixed will need to be rebased if you need to build them again... |
Sorry, I'm didn't understand the issue because I checked in the "Statement.class" and before I pushed all changes fro birt-master-branche into my folk. |
But you are right I created the new local branch before your fix was bushed and after your push I refreshed. |
I'm not such a great Git expert. I personally try to ensure I have master checked out and pulled. Then I create my branch, commit, and push to my fork as the remote. I avoid working on more than one PR at a time. I'm not sure how to manually rebase after master has diverged. My poor man's approach is to rename the branch. Check out master and pull. Create a new branch with the same name as I used before. Cherry pick the change from the renamed branch on the newly-created branch, and force push to my fork. I'm sure there's a better way. 😱 |
Fix prepared statement setNull() #1365