You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I appreciate the code changes, this PR contains unrelated commits.
I just want to mention this (I've made this mistake myself as well).
Perhaps you should wait for a review before merging next time.
Yes, I saw it. Normally I wouldn't merge such combination of 2 different topics.
I don't know why Git recognized both changes. Because I created competely new branch and before I fetched all changes from the master. The second change is from my PR of "prepared statement"-fix.
And the merge to the master shows that there was only 1 file changed which is the same result on my local staging result was.
Sometimes it confused me, because it is hard if the local git-staging comes to another result like the web-git.
So yes, before I have done it I tribble checked the changes from ym side. But you are right it isn't perfect(!)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix align issue of "inline" elements (#1372)