Use batik instead of flute for CSS parsing #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume there are no concerns with this simplification... |
|
Yes, we can use the batik style parser. I check the flute-version on github and the latest changes of it are very old, so it make really sense to switch. |
|
Exactly! I was looking for an update and that screamed, use something else! 😱 It was a bit tricky to get it working, but in the end, just a few simple changes were necessary, so I'm personally happy with that... |
speckyspooky
added
Dependencies
|
Yes, I know what you mean. At the beginning so much research & try to get working and at the and the sum of changes looks sometime so small. A very good idea to move to the existing dependency of batik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1480