Fixing different eclipse warnings (missing comments, unused parameters, static constants access) (#1486) #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
static constants access) (eclipse-birt#1486)
wimjongman
requested changes
Nov 12, 2023
.../org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/layout/emitter/IPage.java
Show resolved
Hide resolved
| @@ -195,10 +235,20 @@ public void newLine(boolean endParagraph) throws BirtException { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Get the fre space | |||
| import org.eclipse.birt.report.engine.layout.pdf.font.FontInfo; | ||
| import org.w3c.dom.css.CSSValue; | ||
|
|
||
| /** | ||
| * Class to implements the text style |
There was a problem hiding this comment.
sorry, which typo?
There was a problem hiding this comment.
remove the s from implements
| public int getWordSpacing() { | ||
| return wordSpacing; | ||
| } | ||
|
|
||
| /** | ||
| * Check if text is underlined |
| /** | ||
| * Check if text is underlined | ||
| * | ||
| * @return Return the check result |
| public boolean isLinethrough() { | ||
| return lineThrough; | ||
| } | ||
|
|
||
| /** | ||
| * Check if the text is underlined |
There was a problem hiding this comment.
underlined or overlined?
There was a problem hiding this comment.
will be changed to "overlined"
| /** | ||
| * Check if the text is underlined | ||
| * | ||
| * @return Return the check result |
| /** | ||
| * Get the text direction | ||
| * | ||
| * @return Return the text direction |
There was a problem hiding this comment.
What are the valid values?
There was a problem hiding this comment.
I haven't checked all at all normaly RTL and LTR
| * Check if the text has a hyperlink | ||
| * | ||
| * @return Return the check result | ||
| */ |
| public boolean isHasHyperlink() { | ||
| return hasHyperlink; | ||
| } | ||
|
|
||
| /** | ||
| * Set the text use a hyperlink |
There was a problem hiding this comment.
non descriptive javadoc
There was a problem hiding this comment.
will be changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes the fixing of different eclipse warnings: