-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A bit of refactoring in the data engine, to improve type safety #1531
A bit of refactoring in the data engine, to improve type safety #1531
Conversation
I see that the commit message is wrong. In fact I started with the intention to fix endless JDBC ParameterMetaData log messages, but then I saw that the code used untyped collections everywhere. So I began to add types to the collections. I commited, and later continued with the typing work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked the replaces and the changes to the typed collections looks good.
@wimjongman Can you take a look at the code? |
Sorry, I have no time to take a proper look at this. |
@hvbtup I think this generally looks fine. Downstream clients would be using mostly raw types at this point so mostly such changes would have no impact because the erasures stay the same... |
Thanks, Ed! |
Improve type safety (eclipse-birt#1531)
There are no functional changes.
Added types to many collections.
Removed unnecessary casts.
Removed unnecessary
SuppressWarnings
tags.Removed the class PropertySecurity, because it just routed to
System.getProperty
.Simplified some if-else constructs as suggested from the IDE.
All of this in an attempt to make the code at least a little bit more comprehensible.