Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the docx issue with the unset margin of the header-footer-container (#1547) #1552

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Fix the docx issue with the unset margin of the header-footer-container (#1547) #1552

merged 1 commit into from
Jan 25, 2024

Conversation

speckyspooky
Copy link
Contributor

No description provided.

@speckyspooky
Copy link
Contributor Author

I created a new method "writeTableCellMarginZero()" which create only the zero-margin-tag of docx.
The method will be called from "startTable()" (like before as single instructions) and new is the call of the new method through "startHeaderFooterContainer()".

Header w/o margin, footer with margin

example-header-wo-margin-footer-w-margin

@speckyspooky speckyspooky self-assigned this Jan 24, 2024
@speckyspooky speckyspooky added the BugFix Change to correct issues label Jan 24, 2024
@speckyspooky speckyspooky added this to the 4.15 milestone Jan 24, 2024
@speckyspooky speckyspooky mentioned this pull request Jan 24, 2024
Closed
wimjongman
wimjongman approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Thomas!

@speckyspooky speckyspooky merged commit f32bef1 into eclipse-birt:master Jan 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wimjongman wimjongman wimjongman approved these changes

@hvbtup hvbtup Awaiting requested review from hvbtup

Assignees

@speckyspooky speckyspooky

Labels
BugFix Change to correct issues
Projects
None yet
Milestone
4.15
Development

Successfully merging this pull request may close these issues.
2 participants
@speckyspooky @wimjongman