-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eclipse warnings and add java documentation, part 3 (#1670) #1698
Fix eclipse warnings and add java documentation, part 3 (#1670) #1698
Conversation
Hello Wim, To solve warnings I changed 2 interfaces and 1 abstract class. With this change we are more safty at side of data type casting What is your opinion on it? I would keep it changed but I will wait for your recommedation of the change. Details of the interface changes:class/interface: public interface IElement => changed:
class/interface: public class AbstractElement implements IElement => changed:
class/interface: public interface IPageContent extends IContainerContent => changed:
|
Yes, if this is a breaking interface change then we can probably not do that without a proper process. |
I have not changed parameter-signatures of methods and I have also not added or removed parameters. I have changed the return-value from raw type "Collection" to "Collection". It is little bit a kind of mixture like your linked documentation and the marked line at my screen. I figured out this sequence of the description which shows me like my change of a raw-type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏🙏
Fix eclipse warnings and add java documentation, part 3 (#1670)
and warnings of JavaScript ECMAScript 6 (#1574)