Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid trying to sign redundant launchers that don't exist #1722

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Jun 7, 2024

No description provided.

@merks merks self-assigned this Jun 7, 2024
@merks
Copy link
Contributor Author

merks commented Jun 7, 2024

The master build signed these:

[INFO] --- eclipse-winsigner:1.4.3:sign (sign) @ birt-report-all-in-one ---
[INFO] [Fri Jun 07 11:14:07 UTC 2024] Signing Windows executable '/home/jenkins/agent/workspace/build_master/build/birt-packages/birt-report-all-in-one/target/products/org.eclipse.birt.report.designer.all/win32/win32/x86_64/eclipse/birt.exe'
[INFO] [Fri Jun 07 11:14:09 UTC 2024] Signing Windows executable '/home/jenkins/agent/workspace/build_master/build/birt-packages/birt-report-all-in-one/target/products/org.eclipse.birt.report.designer.all/win32/win32/x86_64/eclipse/birtc.exe'b

But then failed because these no longer exist:

[ERROR] Failed to execute goal org.eclipse.cbi.maven.plugins:eclipse-winsigner-plugin:1.4.3:sign (sign) on project birt-report-all-in-one: [Fri Jun 07 11:14:13 UTC 2024] Path '/home/jenkins/agent/workspace/build_master/build/birt-packages/birt-report-all-in-one/target/products/org.eclipse.birt.report.designer.all/win32/win32/x86_64/eclipse/eclipsec.

But a PR build does no signing so will not test this PR.

@merks merks merged commit 9181696 into eclipse-birt:master Jun 7, 2024
2 of 3 checks passed
@merks merks deleted the pr-remove-eclispe.exe-sign branch June 7, 2024 11:35
@speckyspooky speckyspooky added this to the 4.16 milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants