Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and cleanup the build process #1779

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Jul 2, 2024

  • Garbage collect unused ant and shell scripts.
  • Garbage collect unused checked-in jars.
  • Avoid creating nested within jars as much as possible.

@hvbtup
Copy link
Contributor

hvbtup commented Jul 2, 2024

Ed, I can't look at the changes, but I just want to say that I'm glad you tackle this task.

@merks
Copy link
Contributor Author

merks commented Jul 2, 2024

@hvbtup

I appreciate the good wishes! The build is such a nightmare of complex stuff that represent a major maintenance hurdle. Deleting unused stuff just makes what's left easier to understand and easier to maintain.

One goal in this process here is to figure out why these jars checked in and to replace them with proper dependencies.

image

Of course I'm a bit scared with all the cross ant scripting that something might break, but what I have built locally (via a local Tycho build) all appears to continue to work fine:

image

- Garbage collect unused ant and shell scripts.
- Garbage collect unused checked-in jars.
- Avoid creating nested  within jars as much as possible.
@merks merks merged commit de4a1cf into eclipse-birt:master Jul 3, 2024
3 checks passed
@merks merks deleted the pr-build-cleanup branch July 3, 2024 12:34
@merks
Copy link
Contributor Author

merks commented Jul 3, 2024

@speckyspooky @wimjongman

Given the runtimes are tested as part of the build, I assume that all is okay after this change. But is there some other manual confirmation/testing that you folks do. If something has gone missing, it's best to find out about it sooner than later!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants