Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change parameter encoding from 8859-1 to UTF-8 (#1800) #1805

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Change parameter encoding from 8859-1 to UTF-8 (#1800) #1805

merged 1 commit into from
Jul 20, 2024

Conversation

speckyspooky
Copy link
Contributor

No description provided.

@speckyspooky speckyspooky added the BugFix Change to correct issues label Jul 19, 2024
@speckyspooky speckyspooky added this to the 4.17 milestone Jul 19, 2024
@speckyspooky speckyspooky self-assigned this Jul 19, 2024
@speckyspooky speckyspooky mentioned this pull request Jul 19, 2024
Closed
@speckyspooky speckyspooky requested a review from merks July 19, 2024 20:02
merks
merks approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely best to use an encoding that can encode any Unicode character.

@speckyspooky speckyspooky merged commit 3e93a81 into eclipse-birt:master Jul 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merks merks merks approved these changes

Assignees

@speckyspooky speckyspooky

Labels
BugFix Change to correct issues
Projects
None yet
Milestone
4.17
Development

Successfully merging this pull request may close these issues.
2 participants
@speckyspooky @merks