Reduce org.eclipse.birt.engine.runtime content #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
merks
commented
Jul 24, 2024
merks
commented
- Remove org.eclipse.rcp to eliminate UI dependencies.
- Add a minimized set of additional plugins.
- Remove UI bundles from the org.eclipse.birt.chart.osgi.runtime feature.
- Remove org.eclipse.core.resources from org.eclipse.birt.report.viewer.
- Remove org.eclipse.rcp to eliminate UI dependencies. - Add a minimized set of additional plugins. - Remove UI bundles from the org.eclipse.birt.chart.osgi.runtime feature. - Remove org.eclipse.core.resources from org.eclipse.birt.report.viewer.
|
@speckyspooky @wimjongman @hvbargen @SteveSchafer-Innovent Guys, this significantly reduces the content of the two runtimes; about ~15-20% smaller in bytes. Both runtimes pass their basic tests. The /ReportEngine/lib has 82 jars instead of 141. The /birt.war/WEB-INF/lib/ has 107 jars instead of 166. Any concerns before I merge? FYI, I'm still suspicious out the SWT dependencies. Only the win32 fragment is present so I'm doubtful this can work across different operating system and no one has complained about that. |
|
It sounds very good to me to reduce the dependencies and shrink the runtimes. |
|
Nice. Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.