fixes NPE and wrong assumptions for an assert #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NPE in JDBCDriverInfoManager remove assertion for url != null in Connection adding test for jndi connection without any other properties
garyxue
approved these changes
Oct 19, 2016
flybyray
commented
Oct 20, 2016
| String jndiName = getJndiName( ); | ||
| try | ||
| { | ||
| System.setProperty( Context.INITIAL_CONTEXT_FACTORY, |
There was a problem hiding this comment.
@garyxue @yulinwang
Please take as note that this may not a perfect test, because this System.setProperty should be set/removed in After Before. If it is set it will maybe resist for other tests too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPE in JDBCDriverInfoManager
remove assertion for url != null in Connection
adding test for jndi connection without any other properties
maybe you use the test without the other changes to see that birt has changed its behaviour with jndi name only connection since version 4.4.2