Add realtime expiring handshakes. #1165
Conversation
boaks
force-pushed
the
expire_handshakes
branch
4 times, most recently
from
fb67b6b to
e3aa3d3
Compare
| * @see #handshakeFailed(Throwable) | ||
| * @see #isRemovingConnection() | ||
| */ | ||
| public final void handshakeAborted(Throwable cause) { |
There was a problem hiding this comment.
I do not understand the benefits of this final ?
There was a problem hiding this comment.
The api-changes.json contains:
"justification": "keep API consistent with other similar functions"
FMPOV, similar functions are:
handshakeCompleted or handshakeFailed(Throwable cause), both are already final.
There was a problem hiding this comment.
Without API break in mind :
I don't understand the benefits of all those final keyword. Most of the time I really don't like the use of final for methods or classes.
With API break in mind :
Even if I agree that finalMethodAddedToNonFinalClass is a questionable break, I would not break just for this, mainly because I find final keyword for method a bad idea most of the time.
boaks
force-pushed
the
expire_handshakes
branch
from
e3aa3d3 to
ccbc2fc
Compare
| @@ -176,6 +177,12 @@ | |||
| /** Realtime nanoseconds of last sending a flight */ | |||
| private long flightSendNanos; | |||
|
|
|||
| /** Realtime nanoseconds when handshakes get's expired. */ | |||
| private long nonosExpireTime; | |||
| /** | ||
| * Test, if handshake is expired according nano realtime. | ||
| * | ||
| * Used to mitigate deep sleep during handhsakes. |
There was a problem hiding this comment.
Maybe ? (personally I didn't know deep sleep before those PRs)
Used to mitigate **Android** deep sleep during handhsakes
| * @see #handshakeFailed(Throwable) | ||
| * @see #isRemovingConnection() | ||
| */ | ||
| public final void handshakeAborted(Throwable cause) { |
There was a problem hiding this comment.
Without API break in mind :
I don't understand the benefits of all those final keyword. Most of the time I really don't like the use of final for methods or classes.
With API break in mind :
Even if I agree that finalMethodAddedToNonFinalClass is a questionable break, I would not break just for this, mainly because I find final keyword for method a bad idea most of the time.
Support android/os deep sleep during handshake. Signed-off-by: Achim Kraus <achim.kraus@bosch-si.com>
boaks
force-pushed
the
expire_handshakes
branch
from
ccbc2fc to
2c4e777
Compare
Support android/os deep sleep during handshake.
Signed-off-by: Achim Kraus achim.kraus@bosch-si.com