Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaking TimeGraphNavigatorHandle instances #191

Closed
PatrickTasse opened this issue Apr 4, 2022 · 0 comments · Fixed by #195
Closed

Leaking TimeGraphNavigatorHandle instances #191

PatrickTasse opened this issue Apr 4, 2022 · 0 comments · Fixed by #195

Comments

@PatrickTasse
Copy link
Contributor

The moveEnd method is added as a snap-x-end handler to the document, but it is not removed when the time graph chart navigator handle is destroyed. This causes the time graph navigator handle instance to leak.
PatrickTasse added a commit to PatrickTasse/timeline-chart that referenced this issue Apr 4, 2022
@PatrickTasse
Fix leaking TimeGraphNavigatorHandle instances
6d38ac3 
Remove moveEnd handler method from document event listeners in
destroy().

Fixes eclipse-cdt-cloud#191.

Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
PatrickTasse added a commit to PatrickTasse/timeline-chart that referenced this issue Apr 12, 2022
@PatrickTasse
Fix leaking TimeGraphVerticalScrollbarHandle instances
3e2e4a3 
Add moveEnd handler method to document event listeners in the moveStart
method and remove the listener in the moveEnd method.

Fixes eclipse-cdt-cloud#191.


Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
PatrickTasse added a commit to PatrickTasse/timeline-chart that referenced this issue Apr 12, 2022
@PatrickTasse
Fix leaking TimeGraphVerticalScrollbarHandle instances
aefddb8 
Add moveEnd handler method to document event listeners in the moveStart
method and remove the listener in the moveEnd method.

Fixes eclipse-cdt-cloud#191.

Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
@PatrickTasse PatrickTasse mentioned this issue Apr 12, 2022
Merged
PatrickTasse added a commit that referenced this issue Apr 12, 2022
@PatrickTasse
Fix leaking TimeGraphVerticalScrollbarHandle instances
188c4da 
Add moveEnd handler method to document event listeners in the moveStart
method and remove the listener in the moveEnd method.

Fixes #191.

Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix leaking TimeGraphVerticalScrollbarHandle instances PatrickTasse/timeline-chart
1 participant
@PatrickTasse