Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expected response for adding kubeconfig #572

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Fix expected response for adding kubeconfig #572

merged 1 commit into from
Jul 5, 2022

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jul 5, 2022

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Fix expected response for adding kubeconfig.

What issues does this PR fix or reference?

fixes eclipse-che/che#21480

Is it tested? How?

  1. Deploy Eclipse CHE on k8s platform using chectl
  2. Create a new workspace from one of the samples.
  3. config file should be in ~/.kube/
$ ls ~/.kube/
  1. Open swagger /dashboard/api/swagger and try to use 'Kube Config'
  2. Response code should be 204

Знімок екрана 2022-07-05 о 12 43 56

Знімок екрана 2022-07-05 о 15 12 21

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 requested a review from ibuziuk July 5, 2022 10:03
@olexii4 olexii4 requested a review from akurinnoy as a code owner July 5, 2022 10:03
@che-bot
Copy link
Contributor

che-bot commented Jul 5, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-572

@openshift-ci
Copy link

openshift-ci bot commented Jul 5, 2022

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-dashboard-happy-path e553a18 link true /test v8-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Jul 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit aeb69fc into main Jul 5, 2022
@olexii4 olexii4 deleted the CHE-21480 branch July 5, 2022 14:02
@che-bot che-bot added this to the 7.51 milestone Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http statusCode 500 - Could not add kubeconfig into containers in user namespace for dashboardApi
4 participants