-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "browser you are using is not supported" warning #701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 could you please backport to 7.58.x for 3.4
@akurinnoy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.5 :: dashboard_3.x/170: Console, Changes, Git Data |
Build 3.5 :: sync-to-downstream_3.x/1964: Console, Changes, Git Data |
Build 3.5 :: push-latest-container-to-quay_3.x/1512: Console, Changes, Git Data |
Build 3.5 :: push-latest-container-to-quay_3.x/1512: Copied: dashboard-rhel8; Quay/Brew version mismatch; all Quay images updated; update-digests NOT triggered; |
Build 3.5 :: copyIIBsToQuay/652: Console, Changes, Git Data |
Build 3.5 :: get-sources-rhpkg-container-build_3.x/1894: dashboard : 3.x :: Build 49995862 : quay.io/devspaces/dashboard-rhel8:3.5-9 |
Build 3.5 :: sync-to-downstream_3.x/1964: Build container: devspaces-dashboard synced; /DS_CI/get-sources-rhpkg-container-build_3.x/1894 triggered; |
Build 3.5 :: dashboard_3.x/170: Upstream sync done; /DS_CI/sync-to-downstream_3.x/1964 triggered |
What does this PR do?
This PR removes the banner that warns users about using a not supported browser.
The banner component is not removed but improved for possible further usage.
What issues does this PR fix or reference?
eclipse-che/che#21866