chore: minor tweaks to be consistent w/ new configbump build #926
Conversation
nickboldt
requested review from
akurinnoy,
olexii4 and
ibuziuk
as code owners
|
Click here to review and test in web IDE: |
nickboldt
changed the title
Change-Id: If5170c7d93625ef37d49a108ccce6192eced1550 Signed-off-by: Nick Boldt <nboldt@redhat.com>
nickboldt
force-pushed
the
tweaks_21988
branch
from
b33ff92
to
5a3cd22
Compare
|
/retest |
| uses: docker/login-action@v2 | ||
| with: | ||
| registry: quay.io | ||
| username: ${{ secrets.QUAY_USERNAME }} | ||
| password: ${{ secrets.QUAY_PASSWORD }} | ||
| - | ||
| name: "Docker docker.io Login" |
There was a problem hiding this comment.
removed this because I didn't think we need to push to docker.io and shouldn't need authentication to pull images... but test is now failing? https://github.com/eclipse-che/che-dashboard/actions/runs/6223681358/job/16890210564?pr=926
|
/retest |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-926 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nickboldt, olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.10 :: dashboard_3.x/355: Console, Changes, Git Data |
|
Build 3.10 :: sync-to-downstream_3.x/4871: Console, Changes, Git Data |
|
Build 3.10 :: push-latest-container-to-quay_3.x/3439: Console, Changes, Git Data |
|
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4691: dashboard : 3.x :: Build 55920130 : quay.io/devspaces/dashboard-rhel8:3.10-30 |
|
Build 3.10 :: update-digests_3.x/4512: Console, Changes, Git Data |
|
Build 3.10 :: dashboard_3.x/355: Upstream sync done; /DS_CI/sync-to-downstream_3.x/4871 triggered |
|
Build 3.10 :: operator-bundle_3.x/2123: Console, Changes, Git Data |
|
Build 3.10 :: sync-to-downstream_3.x/4872: Console, Changes, Git Data |
|
Build 3.10 :: push-latest-container-to-quay_3.x/3440: Console, Changes, Git Data |
|
Build 3.10 :: copyIIBsToQuay/1971: Console, Changes, Git Data |
|
Build 3.10 :: sync-to-downstream_3.x/4872: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4692 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.10 :: operator-bundle_3.x/2123: Upstream sync done; /DS_CI/sync-to-downstream_3.x/4872 triggered |
|
Build 3.10 :: dsc_3.x/1442: Console, Changes, Git Data |
|
Build 3.10 :: update-digests_3.x/4512: Detected new images: rebuild operator-bundle |
What does this PR do?
chore: minor tweaks to be consistent w/ new configbump build
Change-Id: If5170c7d93625ef37d49a108ccce6192eced1550
Signed-off-by: Nick Boldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#21988
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.