This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Add list of external images to server when offline registry is built #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To aid in deploying Che in an offline scenario, it's necessary to have a list of images used in plugins. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Adds various options to build.sh script:
--tag, -t [TAG]
Docker image tag to be used for image; default: 'nightly'
--registry, -r [REGISTRY]
Docker registry to be used for image; default 'quay.io'
--organization, -o [ORGANIZATION]
Docker image organization to be used for image; default: 'eclipse'
--offline
Build offline version of registry, with all sample projects
cached in the registry; disabled by default.
--rhel
Build registry using UBI images instead of default
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
requested review from
l0rd,
nickboldt,
rhopp,
skabashnyuk and
vparfonov
as code owners
amisevsk
changed the title
nickboldt
reviewed
Oct 23, 2019
nickboldt
reviewed
Oct 23, 2019
nickboldt
reviewed
Oct 23, 2019
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
|
@nickboldt Sorry for the confusion, that build.sh script was a big ol' copy paste error from plugin registry. Should be fixed now. |
This was referenced Oct 23, 2019
ibuziuk
pushed a commit
to ibuziuk/che-devfile-registry
that referenced
this pull request
Oct 28, 2019
…clipse-che#128) * Add list of external images to server when offline registry is built To aid in deploying Che in an offline scenario, it's necessary to have a list of images used in plugins. Signed-off-by: Angel Misevski <amisevsk@redhat.com> * Improve build.sh to take options Adds various options to build.sh script: --tag, -t [TAG] Docker image tag to be used for image; default: 'nightly' --registry, -r [REGISTRY] Docker registry to be used for image; default 'quay.io' --organization, -o [ORGANIZATION] Docker image organization to be used for image; default: 'eclipse' --offline Build offline version of registry, with all sample projects cached in the registry; disabled by default. --rhel Build registry using UBI images instead of default Signed-off-by: Angel Misevski <amisevsk@redhat.com> * fixup: fix copy-paste errors in build.sh Signed-off-by: Angel Misevski <amisevsk@redhat.com>
ibuziuk
pushed a commit
that referenced
this pull request
Oct 28, 2019
…128) * Add list of external images to server when offline registry is built To aid in deploying Che in an offline scenario, it's necessary to have a list of images used in plugins. Signed-off-by: Angel Misevski <amisevsk@redhat.com> * Improve build.sh to take options Adds various options to build.sh script: --tag, -t [TAG] Docker image tag to be used for image; default: 'nightly' --registry, -r [REGISTRY] Docker registry to be used for image; default 'quay.io' --organization, -o [ORGANIZATION] Docker image organization to be used for image; default: 'eclipse' --offline Build offline version of registry, with all sample projects cached in the registry; disabled by default. --rhel Build registry using UBI images instead of default Signed-off-by: Angel Misevski <amisevsk@redhat.com> * fixup: fix copy-paste errors in build.sh Signed-off-by: Angel Misevski <amisevsk@redhat.com>
monaka
referenced
this pull request
in PizzaFactory/che-devfile-registry
Nov 25, 2019
…128) * Add list of external images to server when offline registry is built To aid in deploying Che in an offline scenario, it's necessary to have a list of images used in plugins. Signed-off-by: Angel Misevski <amisevsk@redhat.com> * Improve build.sh to take options Adds various options to build.sh script: --tag, -t [TAG] Docker image tag to be used for image; default: 'nightly' --registry, -r [REGISTRY] Docker registry to be used for image; default 'quay.io' --organization, -o [ORGANIZATION] Docker image organization to be used for image; default: 'eclipse' --offline Build offline version of registry, with all sample projects cached in the registry; disabled by default. --rhel Build registry using UBI images instead of default Signed-off-by: Angel Misevski <amisevsk@redhat.com> * fixup: fix copy-paste errors in build.sh Signed-off-by: Angel Misevski <amisevsk@redhat.com>
monaka
referenced
this pull request
in PizzaFactory/che-devfile-registry
Nov 25, 2019
…128) * Add list of external images to server when offline registry is built To aid in deploying Che in an offline scenario, it's necessary to have a list of images used in plugins. Signed-off-by: Angel Misevski <amisevsk@redhat.com> * Improve build.sh to take options Adds various options to build.sh script: --tag, -t [TAG] Docker image tag to be used for image; default: 'nightly' --registry, -r [REGISTRY] Docker registry to be used for image; default 'quay.io' --organization, -o [ORGANIZATION] Docker image organization to be used for image; default: 'eclipse' --offline Build offline version of registry, with all sample projects cached in the registry; disabled by default. --rhel Build registry using UBI images instead of default Signed-off-by: Angel Misevski <amisevsk@redhat.com> * fixup: fix copy-paste errors in build.sh Signed-off-by: Angel Misevski <amisevsk@redhat.com>
sparkoo
pushed a commit
to sparkoo/che-devfile-registry
that referenced
this pull request
Dec 4, 2020
Add shellcheck to CircleCI config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds building a list of externally-referenced images to the offline build to make it easier for users to know which images need to be pulled into a private registry.
Required for eclipse-che/che#14866
Also rewrites the
build.shscript to be similar to the one in the plugin registry (with options)