-
Notifications
You must be signed in to change notification settings - Fork 114
Set 0.0.0.0 as a host to run Quarkus app #318
Conversation
Signed-off-by: svor <vsvydenk@redhat.com>
@svor Maybe better to set as an env variable? so it works also when you start from the terminal? do we have the same issue with the native app ? |
@sunix As I see we don't have this issue with the native app: You can try it https://che.openshift.io/factory?url=https://raw.githubusercontent.com/svor/che-devfile-registry/sv/quarkusFix/devfiles/quarkus/devfile.yaml |
Still, I think it is better to set that as an environment variable in the container. |
Screen.Recording.2020-12-18.at.17.28.44.mov |
@sunix If we have this value in env variable, we will get a problem with tests:
|
https://gist.github.com/sunix/2cc2daa838d6be27b425216ff25db3c7#file-quarkus-devfile-yaml-L28-L29 I don't have your error |
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor vsvydenk@redhat.com
What does this PR do?
Set
0.0.0.0
as a host to run Quarkus appScreenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#18512
How to test this PR?
Use this factory: https://che.openshift.io/factory?url=https://raw.githubusercontent.com/svor/che-devfile-registry/sv/quarkusFix/devfiles/quarkus/devfile.yaml
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.