This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Update dockerfile patch and make new java devfiles used patched images #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisevsk
requested review from
l0rd,
rhopp,
skabashnyuk and
vparfonov
as code owners
ibuziuk
approved these changes
Jul 22, 2019
l0rd
approved these changes
Jul 22, 2019
23 tasks
|
@sleshchenko Do you foresee any subtle issues resulting from us no longer using the maven wrapper to build the Spring projects? I've tested with default |
Update the arbitrary users patch to make sure $HOME is always writable,
fixing issues with some images.
Update java-spring, java-mysql, and java-vertx to use patched images
- Update the commands in these images since maven wrapper is
incompatible with community maven image
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
force-pushed
the
update-devfiles
branch
from
b4d1634 to
916fc53
Compare
sparkoo
pushed a commit
to sparkoo/che-devfile-registry
that referenced
this pull request
Dec 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the arbitrary users patch to make sure $HOME is always writable,
fixing issues with some images.
Update
java-spring,java-mysql, andjava-vertxto use patched imagesmaven:3.6.1-jdk-8instead ofregistry.centos.org/che-stacks/centos-jdk8to avoid building another patched image.One change this makes for the spring images is changing the command to not use the maven wrapper. This wrapper is intended to make it easier to use maven (https://github.com/takari/maven-wrapper/) but appears to not be necessary for the image we are using. Additionally the wrapper is incompatible with the maven community image on OpenShift, since the community image defines
$MAVEN_CONFIG=/root/.m2, and the wrapper appears to reuse this env var for (undocumented, afaict) reasons: https://github.com/takari/maven-wrapper/blob/master/mvnw#L301What issues does this PR fix or reference?
Part of eclipse-che/che#13454, redhat-developer/rh-che#1455, some issues raised in #38 (gradle home not writable)
Tested images:
java-vertx,java-spring,java-mysql: Everything works except:.bashrcalready exists so these stacks get an ugly prompt (including workspace ID)java-gradle: This PR fixes the/home/gradledirectory not being writablephp-simple: This PR fixes the/home/userdirectory not being writable.