Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

fix helm chart deployment strategy config #44

Merged
merged 2 commits into from
Jul 22, 2019

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Jul 22, 2019

Signed-off-by: Michal Vala mvala@redhat.com

What does this PR do?

fix helm chart deployment config

What issues does this PR fix or reference?

eclipse-che/che#13890

Signed-off-by: Michal Vala <mvala@redhat.com>
Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks @sparkoo. Can you please update the apiVersion of the deployment to apps/v1 (extensions/v1beta1 is currently deprecated)?

Signed-off-by: Michal Vala <mvala@redhat.com>
@sparkoo
Copy link
Member Author

sparkoo commented Jul 22, 2019

Cool thanks @sparkoo. Can you please update the apiVersion of the deployment to apps/v1 (extensions/v1beta1 is currently deprecated)?

@l0rd done

@sparkoo
Copy link
Member Author

sparkoo commented Jul 22, 2019

@l0rd thanks for the review. If you're happy now and no more review needed, please merge. I don't have permissions here.

@skabashnyuk skabashnyuk merged commit 91f5b9b into eclipse-che:master Jul 22, 2019
nickboldt pushed a commit to nickboldt/che-devfile-registry that referenced this pull request Aug 9, 2019
* fix helm chart deployment strategy config

Signed-off-by: Michal Vala <mvala@redhat.com>
sparkoo pushed a commit to sparkoo/che-devfile-registry that referenced this pull request Dec 4, 2020
Change the name to be Che Samples : Hello World (instead of dummy)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants