Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Fixing Java MySQL sample devfile to be able to be run on OSIO #61

Merged

Conversation

ScrewTSW
Copy link
Member

What does this PR do?

This PR fixes the Java MySQL devfile memory quotas in order to be able to run the devfile on OSIO

What issues does this PR fix or reference?

Issue: https://github.com/redhat-developer/che-functional-tests/issues/556

devfiles/java-mysql/devfile.yaml Outdated Show resolved Hide resolved
devfiles/java-mysql/devfile.yaml Outdated Show resolved Hide resolved
devfiles/java-mysql/devfile.yaml Outdated Show resolved Hide resolved
@ScrewTSW ScrewTSW force-pushed the 556-feature-fix-devfile-quotas-java-mysql branch 3 times, most recently from 9fc29f0 to 55ca0e8 Compare July 25, 2019 14:09
@skabashnyuk
Copy link
Contributor

CC @amisevsk

@amisevsk
Copy link
Contributor

Looking at my quota usage with this devfile, I see 2.77Gi used out of 3Gi available; is there a reason we're not using the remaining ~230Mi quota?

@ScrewTSW
Copy link
Member Author

Looking at my quota usage with this devfile, I see 2.77Gi used out of 3Gi available; is there a reason we're not using the remaining ~230Mi quota?

I can try to fiddle with it and submit a fix to the PR tomorrow.

@amisevsk
Copy link
Contributor

Regardless I've tested and the lowered limit on java LS does not seem to interfere for the sample project. +1 to merge.

@ScrewTSW ScrewTSW force-pushed the 556-feature-fix-devfile-quotas-java-mysql branch from 55ca0e8 to b557a0f Compare July 25, 2019 14:49
@amisevsk
Copy link
Contributor

Looking at this more closely (output of top on the vscode-java container) I can see the language server being killed occasionally and restarted by the plugin. This is accompanied by logs like

[Info  - 2:59:18 PM] Connection to server got closed. Server will restart.
[Info  - 2:59:56 PM] Connection to server got closed. Server will restart.
[Error - 2:59:56 PM] Request textDocument/codeAction failed.
Error: Connection got disposed.
[...]

I also at one point ended up with two java language servers running simultaneously (though I don't know if that's an issue in master)

@ScrewTSW
Copy link
Member Author

ScrewTSW commented Jul 26, 2019

so upon investigation there are three constants consuming quota limits:

  • JWT Proxy consumes 150MiB
  • Machine exec pod consumes 150MiB
  • Theia consumes 512MB = 488.281MiB

and the plugins defined in the devfile:

  • mysql : 256MiB (+44MiB new value 300MiB)
  • Java LSP : set to 1280MiB - Should be enough to avoid LSP OOM restart
  • tools (maven) : 700MiB

That leaves me 1327.71875MiB to redistribute. After redistribution this leaves me exactly 3899392 bytes to spare or 3.71875MiB .

I've opened every single file, tried jump to definition, jump to implementation, code completion and code correction.

mysql peaked at 245MiB
Java LSP peaked at 950MiB and remained stable
Maven peaked at 350 MiB during build and then around 380 during application deployment

@ScrewTSW ScrewTSW changed the title Fixing Java MySQL sample devfile to be able to be run on OSIO WIP: Fixing Java MySQL sample devfile to be able to be run on OSIO Jul 26, 2019
@ScrewTSW ScrewTSW force-pushed the 556-feature-fix-devfile-quotas-java-mysql branch from ead5add to d458146 Compare July 26, 2019 14:40
@ScrewTSW ScrewTSW closed this Jul 26, 2019
@ScrewTSW ScrewTSW force-pushed the 556-feature-fix-devfile-quotas-java-mysql branch from d458146 to b4a78f9 Compare July 26, 2019 14:41
…nshift.io)

Signed-off-by: Tibor Dancs <tdancs@redhat.com>
@ScrewTSW ScrewTSW reopened this Jul 26, 2019
@ScrewTSW ScrewTSW changed the title WIP: Fixing Java MySQL sample devfile to be able to be run on OSIO Fixing Java MySQL sample devfile to be able to be run on OSIO Jul 29, 2019
@ibuziuk ibuziuk merged commit 673bdf8 into eclipse-che:master Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants