This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Update NodeJS-MongoDB devfile to use new sample #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svor <vsvydenk@redhat.com>
svor
requested review from
amisevsk,
l0rd,
rhopp,
skabashnyuk and
vparfonov
as code owners
amisevsk
reviewed
Sep 23, 2019
There was a problem hiding this comment.
One suggestion below. I also get a notification when running:
A new process is now listening on port 9229 but is listening on interface 127.0.0.1 which is internal. You should change to be remotely available. Would you want to add a redirect for this port so it becomes available ?
but that is probably a separate issue.
Apart from that I've briefly tested and it works well.
Signed-off-by: svor <vsvydenk@redhat.com>
amisevsk
approved these changes
Sep 24, 2019
tolusha
approved these changes
Oct 3, 2019
monaka
referenced
this pull request
in PizzaFactory/che-devfile-registry
Nov 25, 2019
* Update NodeJS-MongoDB devfile to use new sample Signed-off-by: svor <vsvydenk@redhat.com> * Fix endpoint port Signed-off-by: svor <vsvydenk@redhat.com>
monaka
referenced
this pull request
in PizzaFactory/che-devfile-registry
Nov 25, 2019
* Update NodeJS-MongoDB devfile to use new sample Signed-off-by: svor <vsvydenk@redhat.com> * Fix endpoint port Signed-off-by: svor <vsvydenk@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: svor vsvydenk@redhat.com
What does this PR do?
Updates stack for developing nodeJS+mongoDB web application.
The application is https://github.com/che-samples/nodejs-mongodb-sample
The demo about how it works: https://youtu.be/UYTpVw2uasI
What issues does this PR fix or reference?
eclipse-che/che#14392