Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Eclipse Che uses storage classes. #1039

Merged
merged 3 commits into from
Feb 10, 2020

Conversation

AndrienkoAleksandr
Copy link
Contributor

What does this PR do?

Define flow how administrator can configure persisted volumes storage for Eclipse Che using storage class name.

What issues does this PR fix or reference?

eclipse-che/che#15157

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@tolusha
Copy link
Contributor

tolusha commented Jan 23, 2020

@themr0c
Could you validate the PR ?

Signed-off-by: Yana Hontyk <yhontyk@redhat.com>
@themr0c
Copy link
Contributor

themr0c commented Jan 31, 2020

Hi @boczkowska made a review and has some suggestions that should be integrated before we merge, can you have a look at them (and merge them)? See: https://github.com/eclipse/che-docs/pull/1062/files

Language and formatting suggestions (review for 1039 PR).
@AndrienkoAleksandr
Copy link
Contributor Author

I merged pr from @boczkowska.
@themr0c or @tolusha could you approve current pr to make merge possible?

@AndrienkoAleksandr AndrienkoAleksandr merged commit 1ff617c into master Feb 10, 2020
@AndrienkoAleksandr AndrienkoAleksandr deleted the installCheUsingStorageClasses branch February 10, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants