Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links for installation on Kind cluster #1280

Merged
merged 2 commits into from
May 22, 2020
Merged

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented May 21, 2020

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Updates Eclipse Che installation process on Kind Kubernetes cluster.
Some broken links fixed, added some warnings and explanations.

What issues does this PR fix or reference?

eclipse-che/che#16792
eclipse-che/che#16794

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Copy link
Contributor

@tomgeorge tomgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! This clarifies and cleans up a lot of the kind docs.

@mmorhun mmorhun marked this pull request as ready for review May 22, 2020 06:18
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun mmorhun merged commit 357a580 into master May 22, 2020
@mmorhun mmorhun deleted the deploy-on-kind-fix branch May 22, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants