Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change docs according self-signed certificate flag automation #1331

Merged
merged 5 commits into from
Jun 30, 2020

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Jun 24, 2020

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Updates docs according to automation of --self-signed-certificate flag.

What issues does this PR fix or reference?

eclipse-che/che#16764
eclipse-che/che#15301

Specify the version of the product this PR applies to.

Eclipse Che 7.15.0

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@rkratky rkratky self-assigned this Jun 24, 2020
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted my review and suggested changes in #1340.

@@ -16,21 +16,55 @@ summary:

:context: installing-{prod-id-short}-in-tls-mode-with-self-signed-certificates

WARNING: This guide is for development only. Do not use self-signed certificates in production.
WARNING: Self-signed certificates is usually used in development and evaluation enviromnents. If you want to use them in production you should understand the consequences.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
WARNING: Self-signed certificates is usually used in development and evaluation enviromnents. If you want to use them in production you should understand the consequences.
WARNING: Self-signed certificates are usually used in development and evaluation environments. Use in production environments is not recommended.

@rkratky
Copy link

rkratky commented Jun 30, 2020

@mmorhun, thanks for the updates. As mentioned in #1340, I'm merging this in your absence, but I'll be happy to revisit it if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants