-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change docs according self-signed certificate flag automation #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
...-7/installation-guide/assembly_installing-che-in-tls-mode-with-self-signed-certificates.adoc
Outdated
Show resolved
Hide resolved
14 tasks
rkratky
suggested changes
Jun 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitted my review and suggested changes in #1340.
@@ -16,21 +16,55 @@ summary: | |||
|
|||
:context: installing-{prod-id-short}-in-tls-mode-with-self-signed-certificates | |||
|
|||
WARNING: This guide is for development only. Do not use self-signed certificates in production. | |||
WARNING: Self-signed certificates is usually used in development and evaluation enviromnents. If you want to use them in production you should understand the consequences. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
WARNING: Self-signed certificates is usually used in development and evaluation enviromnents. If you want to use them in production you should understand the consequences. | |
WARNING: Self-signed certificates are usually used in development and evaluation environments. Use in production environments is not recommended. |
rkratky
approved these changes
Jun 30, 2020
This was referenced Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do?
Updates docs according to automation of
--self-signed-certificate
flag.What issues does this PR fix or reference?
eclipse-che/che#16764
eclipse-che/che#15301
Specify the version of the product this PR applies to.
Eclipse Che 7.15.0