Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review #2133

Merged
merged 15 commits into from
Oct 21, 2021
Merged

review #2133

merged 15 commits into from
Oct 21, 2021

Conversation

MichalMaler
Copy link
Contributor

Signed-off-by: Michal Maléř mmaler@redhat.com

Review for #2124

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@MichalMaler MichalMaler requested review from rkratky, themr0c and a team as code owners October 11, 2021 12:10
@MichalMaler MichalMaler requested review from davidfestal and removed request for a team October 11, 2021 12:10
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@MichalMaler MichalMaler added cherry-picked to 7.36.x for CRW 2.12 and removed cherry-picked to 7.36.x for CRW 2.12 labels Oct 21, 2021
@MichalMaler
Copy link
Contributor Author

My changes was applied directly to the https://github.com/eclipse/che-docs/tree/crw-1497 by @tolusha, since it was easier thatn solving my conflicts.
Thx for great coop: @tolusha @mmorhun

Closing this now

@MichalMaler MichalMaler reopened this Oct 21, 2021
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

1 similar comment
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@MichalMaler MichalMaler merged commit c02c25c into eclipse-che:crw-1497 Oct 21, 2021
@MichalMaler MichalMaler deleted the crw-1497-mmaler-review branch October 21, 2021 13:46
MichalMaler added a commit that referenced this pull request Oct 21, 2021
* Update restore docs to include new rollback feature

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

* Rephrase backup server choosing algorithm

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

* Remove last backup server context mention

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

* Procedures: Che backup review (#2140)

* MMaler-brief-review

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fix

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* vale

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* Applying https://github.com/MichalMaler/che-docs/tree/crw-1497-mmaler-review

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Revert "Applying https://github.com/MichalMaler/che-docs/tree/crw-1497-mmaler-review"

This reverts commit eaeb8c3.

* Reverting ..

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* review (#2133)

* review

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* sync

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* xref fix

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* renaming

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* renaming

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fixes

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* xref

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fix

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* html test failures fix

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fixes

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* vale

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* html test fix

Signed-off-by: Michal Maléř <mmaler@redhat.com>

Co-authored-by: Anatolii Bazko <abazko@redhat.com>
Co-authored-by: Michal Maléř <mmaler@redhat.com>
@themr0c themr0c added this to the 7.42 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants