fix: add extra steps for monitoring docs #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 Navigate the preview: https://62b9c9a770930d4cffbd14da--eclipse-che-docs-pr.netlify.app 🎊 |
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
dkwon17
commented
Jun 17, 2022
modules/administration-guide/examples/snip_che-create-monitoring-namespace.adoc
Show resolved
Hide resolved
|
@themr0c could you please review? |
max-cx
reviewed
Jun 23, 2022
modules/administration-guide/pages/installing-prometheus-and-grafana.adoc
Outdated
Show resolved
Hide resolved
max-cx
reviewed
Jun 23, 2022
modules/administration-guide/pages/installing-prometheus-and-grafana.adoc
Outdated
Show resolved
Hide resolved
max-cx
reviewed
Jun 23, 2022
modules/administration-guide/pages/installing-prometheus-and-grafana.adoc
Outdated
Show resolved
Hide resolved
max-cx
reviewed
Jun 23, 2022
modules/administration-guide/examples/snip_che-create-monitoring-namespace.adoc
Outdated
Show resolved
Hide resolved
max-cx
reviewed
Jun 23, 2022
modules/administration-guide/partials/proc_collecting-che-metrics-with-prometheus.adoc
Outdated
Show resolved
Hide resolved
max-cx
reviewed
Jun 23, 2022
modules/administration-guide/partials/proc_collecting-che-metrics-with-prometheus.adoc
Outdated
Show resolved
Hide resolved
max-cx
reviewed
Jun 23, 2022
modules/administration-guide/partials/proc_collecting-che-metrics-with-prometheus.adoc
Outdated
Show resolved
Hide resolved
max-cx
reviewed
Jun 23, 2022
modules/administration-guide/partials/proc_collecting-che-metrics-with-prometheus.adoc
Outdated
Show resolved
Hide resolved
max-cx
reviewed
Jun 23, 2022
modules/administration-guide/partials/proc_collecting-che-metrics-with-prometheus.adoc
Outdated
Show resolved
Hide resolved
max-cx
reviewed
Jun 23, 2022
modules/administration-guide/partials/proc_collecting-che-metrics-with-prometheus.adoc
Outdated
Show resolved
Hide resolved
max-cx
reviewed
Jun 23, 2022
modules/administration-guide/partials/proc_collecting-che-metrics-with-prometheus.adoc
Outdated
Show resolved
Hide resolved
max-cx
reviewed
Jun 23, 2022
...istration-guide/partials/proc_collecting-dev-workspace-operator-metrics-with-prometheus.adoc
Outdated
Show resolved
Hide resolved
max-cx
reviewed
Jun 23, 2022
...istration-guide/partials/proc_collecting-dev-workspace-operator-metrics-with-prometheus.adoc
Outdated
Show resolved
Hide resolved
max-cx
reviewed
Jun 23, 2022
...istration-guide/partials/proc_collecting-dev-workspace-operator-metrics-with-prometheus.adoc
Outdated
Show resolved
Hide resolved
max-cx
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
- The preview looks good.
- Pls review my two last-minute suggestions:
https://github.com/eclipse-che/che-docs/pull/2379/files#r907162683
https://github.com/eclipse-che/che-docs/pull/2379/files#r907163564 - You need to rebase this branch on
main.
Signed-off-by: David Kwon <dakwon@redhat.com>
…rafana.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…rafana.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…rafana.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…ics-with-prometheus.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…ics-with-prometheus.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…ics-with-prometheus.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…ics-with-prometheus.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…ics-with-prometheus.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…space-operator-metrics-with-prometheus.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…space-operator-metrics-with-prometheus.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…space-operator-metrics-with-prometheus.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
Signed-off-by: David Kwon <dakwon@redhat.com>
…ics-with-prometheus.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…space-operator-metrics-with-prometheus.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
dkwon17
force-pushed
the
monitoring-improvement-main
branch
from
5577261
to
cf73ff8
Compare
|
Thank you @max-cx , I've applied the two suggestions and rebased 👍 |
max-cx
added a commit
to max-cx/che-docs
that referenced
this pull request
Jun 28, 2022
* fix: add extra steps for monitoring docs Signed-off-by: David Kwon <dakwon@redhat.com> Co-authored-by: Max Leonov <mleonov@redhat.com>
max-cx
added a commit
to max-cx/che-docs
that referenced
this pull request
Jun 28, 2022
* fix: add extra steps for monitoring docs Signed-off-by: David Kwon <dakwon@redhat.com> Co-authored-by: Max Leonov <mleonov@redhat.com>
max-cx
added a commit
to max-cx/che-docs
that referenced
this pull request
Jun 29, 2022
* fix: add extra steps for monitoring docs Signed-off-by: David Kwon <dakwon@redhat.com> Co-authored-by: Max Leonov <mleonov@redhat.com>
max-cx
added a commit
to max-cx/che-docs
that referenced
this pull request
Jun 29, 2022
* fix: add extra steps for monitoring docs Signed-off-by: David Kwon <dakwon@redhat.com> Co-authored-by: Max Leonov <mleonov@redhat.com>
max-cx
added a commit
to max-cx/che-docs
that referenced
this pull request
Jun 29, 2022
* fix: add extra steps for monitoring docs Signed-off-by: David Kwon <dakwon@redhat.com> Co-authored-by: Max Leonov <mleonov@redhat.com>
max-cx
added a commit
to max-cx/che-docs
that referenced
this pull request
Jun 29, 2022
* fix: add extra steps for monitoring docs Signed-off-by: David Kwon <dakwon@redhat.com> Co-authored-by: Max Leonov <mleonov@redhat.com>
max-cx
added a commit
to max-cx/che-docs
that referenced
this pull request
Jul 7, 2022
* fix: add extra steps for monitoring docs Signed-off-by: David Kwon <dakwon@redhat.com> Co-authored-by: Max Leonov <mleonov@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Kwon dakwon@redhat.com
What does this pull request change?
This PR adds/changes steps to the monitoring docs to make them easier to follow along:
What issues does this pull request fix or reference?
eclipse-che/che#21444
Specify the version of the product this pull request applies to
stable, next
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.