Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: URL parameter for configuring remotes #2531

Merged
merged 9 commits into from
Jan 26, 2023
Merged

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Dec 21, 2022

Signed-off-by: dkwon17 dakwon@redhat.com

What does this pull request change?

Adds a URL parameter for configuring project remotes section in the user guide.

image

What issues does this pull request fix or reference?

This PR is to document the feature added by this PR: eclipse-che/che-dashboard#691

Specify the version of the product this pull request applies to

Che 7.59

(This feature was Backported to Che 7.58, therefore can be available for DS 3.4)

main and cherry-pick to 7.58

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Signed-off-by: dkwon17 <dakwon@redhat.com>
@dkwon17 dkwon17 requested review from rkratky, themr0c, max-cx and a team as code owners December 21, 2022 04:04
@dkwon17 dkwon17 requested a review from svor December 21, 2022 04:04
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Dec 21, 2022

🎊 Navigate the preview: https://63d244fee3215c27e6c97459--eclipse-che-docs-pr.netlify.app 🎊

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@ibuziuk
Copy link
Member

ibuziuk commented Dec 22, 2022

@max-cx could you please review?

@max-cx max-cx self-assigned this Jan 9, 2023
dkwon17 and others added 3 commits January 9, 2023 11:29
…ject-remotes.adoc

Co-authored-by: Nick Boldt <nboldt@redhat.com>
…ject-remotes.adoc

Co-authored-by: Nick Boldt <nboldt@redhat.com>
…ject-remotes.adoc

Co-authored-by: Nick Boldt <nboldt@redhat.com>
Signed-off-by: dkwon17 <dakwon@redhat.com>
Signed-off-by: dkwon17 <dakwon@redhat.com>
@ibuziuk
Copy link
Member

ibuziuk commented Jan 24, 2023

@max-cx can we merge the PR now?

Copy link
Contributor

@max-cx max-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed this PR and propose a rewrite in dkwon17#15.

@max-cx
Copy link
Contributor

max-cx commented Jan 25, 2023

Also, I'd like to suggest documenting the other way of doing this (without specifying the remote names) as an admonition like TIP. Please correct me if I am wrong, but my current understanding is that explicitly specifying the names of the additional remotes manually by the user offers more flexibility in terms of which remote becomes the origin and is checked out, which might cover more use cases. If that is true, then that would be the number one choice in the docs. And I wouldn't recommend offering readers multiple ways of doing the same thing as separate and parallel sections in the docs.

@dkwon17
Copy link
Contributor Author

dkwon17 commented Jan 25, 2023

@max-cx yes, documenting the other way of doing this as an admonition/TIP sounds good to me

@max-cx max-cx merged commit 5676a66 into eclipse-che:main Jan 26, 2023
@che-bot che-bot added this to the 7.60 milestone Jan 26, 2023
max-cx added a commit that referenced this pull request Jan 26, 2023
* docs: URL parameter for configuring remotes

Signed-off-by: dkwon17 <dakwon@redhat.com>

* Update modules/end-user-guide/pages/url-parameter-for-configuring-project-remotes.adoc

Co-authored-by: Nick Boldt <nboldt@redhat.com>

* Update modules/end-user-guide/pages/url-parameter-for-configuring-project-remotes.adoc

Co-authored-by: Nick Boldt <nboldt@redhat.com>

* Update modules/end-user-guide/pages/url-parameter-for-configuring-project-remotes.adoc

Co-authored-by: Nick Boldt <nboldt@redhat.com>

* Small wording change, add xref

Signed-off-by: dkwon17 <dakwon@redhat.com>

* Remove <1>

Signed-off-by: dkwon17 <dakwon@redhat.com>

* initial edits

* Update modules/end-user-guide/pages/url-parameter-for-additional-remotes.adoc

Signed-off-by: dkwon17 <dakwon@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Max Leonov <mleonov@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants