-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deploying Che with self-signed certificate #2625
Conversation
🎊 Navigate the preview: https://64b91b58ca790372c00f6188--eclipse-che-docs-pr.netlify.app 🎊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a small suggestion added, otherwise lgtm
modules/administration-guide/pages/deploying-che-with-self-signed-certificate.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one extra edit
modules/administration-guide/pages/deploying-che-with-self-signed-certificate.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-che-on-minikube.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-che-on-minikube-keycloak-oidc.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
…ned-certificate.adoc Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…ned-certificate.adoc Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
Co-authored-by: Max Leonov <mleonov@redhat.com>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
Co-authored-by: Max Leonov <mleonov@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
What does this pull request change?
feat: Deploying Che with self-signed certificate
What issues does this pull request fix or reference?
eclipse-che/che#22349
Specify the version of the product this pull request applies to
main
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.