Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deploying Che with self-signed certificate #2625

Merged
merged 13 commits into from
Jul 20, 2023
Merged

feat: Deploying Che with self-signed certificate #2625

merged 13 commits into from
Jul 20, 2023

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jul 13, 2023

What does this pull request change?

feat: Deploying Che with self-signed certificate

What issues does this pull request fix or reference?

eclipse-che/che#22349

Specify the version of the product this pull request applies to

main

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@github-actions
Copy link

github-actions bot commented Jul 13, 2023

🎊 Navigate the preview: https://64b91b58ca790372c00f6188--eclipse-che-docs-pr.netlify.app 🎊

@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Click here to review and test in web IDE: Contribute

@tolusha tolusha marked this pull request as ready for review July 14, 2023 09:44
@tolusha tolusha requested review from rkratky, max-cx, deerskindoll and a team as code owners July 14, 2023 09:44
@tolusha tolusha requested a review from nickboldt July 14, 2023 09:44
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small suggestion added, otherwise lgtm

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one extra edit

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tolusha and others added 7 commits July 20, 2023 13:25
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
…ned-certificate.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…ned-certificate.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
…adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>
tolusha and others added 6 commits July 20, 2023 13:25
Co-authored-by: Max Leonov <mleonov@redhat.com>
…keycloak-oidc.adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>
Co-authored-by: Max Leonov <mleonov@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha merged commit 5e0ea9b into main Jul 20, 2023
6 checks passed
@tolusha tolusha deleted the 22349 branch July 20, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants