Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configuring number of replicas #2676

Merged
merged 2 commits into from
Feb 14, 2024
Merged

feat: configuring number of replicas #2676

merged 2 commits into from
Feb 14, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jan 31, 2024

What does this pull request change?

Configuring number of replicas

What issues does this pull request fix or reference?

eclipse-che/che#22067

Specify the version of the product this pull request applies to

main

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@tolusha tolusha requested review from deerskindoll and a team as code owners January 31, 2024 12:08
@tolusha tolusha requested a review from svor January 31, 2024 12:08
Copy link

github-actions bot commented Jan 31, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Jan 31, 2024

🎊 Navigate the preview: https://65cb4a3ac1439e0098592ee8--eclipse-che-docs-pr.netlify.app 🎊

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits + a Vale fix

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional Vale error found

…of-replicas.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Feb 14, 2024

@deerskindoll
Can I merge?

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deerskindoll
Copy link
Contributor

@deerskindoll Can I merge?

@tolusha go for it

@tolusha tolusha merged commit da474ae into main Feb 14, 2024
10 checks passed
@tolusha tolusha deleted the 22067 branch February 14, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants