-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for the che_workspace_failure_total and che_workspace_status metrics. #658
Conversation
release-notes/release-6.17.0.md
Outdated
|
||
Eclipse Che 6.17 includes: | ||
|
||
* **Workspace failure count metric**: Prometheus metric counting the number of workspace failures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description here should be from the point of view of user benefit, and should be descriptive: "Keep track of workspace failures" is better. The description should be a sentence: "Added a metric to Prometheus to count the number of workspace failures".
release-notes/release-6.17.0.md
Outdated
|
||
## Release details | ||
|
||
### Workspace failure count metric |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title should be more descriptive - same as the summary; I suggest "Keep track of workspace failures" is easier to parse.
Have the comments been resolved here? I could merge and fix in-place post-merge, if that works better for the Dev teams, but I would like to ensure that RN changes use a consistent format to reduce rework. |
Sorry for the delay, somehow I didn't notice your comments. I changed the wording according to your suggestions. Thanks! |
This PR now also supersedes #656. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
What does this PR do?
Add release notes for the
che_workspace_failure_total
andche_workspace_status
metrics.What issues does this PR fix or reference?
eclipse-che/che#12242
eclipse-che/che#12368
eclipse-che/che#12092