Improve dev file #42
Merged
Improve dev file #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on the minishift. Improve devfile tasks. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
evidolob,
l0rd,
rhopp and
vparfonov
as code owners
evidolob
approved these changes
Aug 12, 2019
mmorhun
approved these changes
Aug 12, 2019
|
is target Che 7.0.0 ? |
We use this devfile only for development and in the CONTRIUBTING.md file to notify user how to develop che-machine-exec component. Merge this pr doesn't break che-machine-exec image or binary at all. So I think we can safely merge it. |
Ok, thanks |
vparfonov
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issue:
eclipse-che/che#14195
Requested changes: