Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

che #14947: Releasing 7.3.1 version of the che-machine-exec. Adding rhel.Dockerfile #50

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Oct 28, 2019

Che issue - eclipse-che/che#14947
Adding rhel.Dockerfile from:

…hel.Dockerfile

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk ibuziuk requested a review from nickboldt October 28, 2019 10:09
@l0rd l0rd mentioned this pull request Oct 28, 2019
30 tasks
@ibuziuk ibuziuk merged commit 173e2aa into eclipse-che:7.3.x Oct 28, 2019
#

# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/rhel8/go-toolset
FROM rhel8/go-toolset:1.11.13-18 as builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this image is not public it can't be used in Eclipse Che

Copy link
Member Author

@ibuziuk ibuziuk Oct 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickboldt I have no idea why the rhel image was added in general without proper ci setup? Could you clarify?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not used in Che. It's a secondary image that makes it easier for upstream to remember that there's a downstream, so if they update Dockerfile they MIGHT remember to apply similar change to rhel.Dockerfile. But it's not strictly an artifact that's USED in the Che build process

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but for devfile & plugin registry we do build rhel image as part of CI. Does it make sense to do the same for che-machine-exec. In the current state presense of this RHEL image is misleading IMO

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well then there are two options:

a) keep it up here i che-machine-exec and DO build it as part of CI

b) remove it and hope that not having a rhel version in upstream causes any downstream impacts when I have to absorb changes from up to down and can't find an SME online (due to TZ conflicts).

I'd prefer (a). In fact I'd prefer if building on UBI8 was the default, not an option, but hey. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants